Support for .NET Core 3.0 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 94.94% 95.83% +0.88%
==========================================
Files 19 19
Lines 455 456 +1
==========================================
+ Hits 432 437 +5
+ Misses 23 19 -4
Continue to review full report at Codecov.
|
|
Some 2.2 vs 3.0 benchmarks, which basically show a modest improvement for UDP of ~4% but a ~14% improvement for IP. .NET Core 2.2BenchmarkDotNet=v0.11.5, OS=Windows 10.0.18362
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.0.100-preview8-013656
[Host] : .NET Core 2.2.6 (CoreCLR 4.6.27817.03, CoreFX 4.6.27818.02), 64bit RyuJIT
DefaultJob : .NET Core 2.2.6 (CoreCLR 4.6.27817.03, CoreFX 4.6.27818.02), 64bit RyuJIT
.NET Core 3.0 preview 8BenchmarkDotNet=v0.11.5, OS=Windows 10.0.18362
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=3.0.100-preview8-013656
[Host] : .NET Core 3.0.0-preview8-28405-07 (CoreCLR 4.700.19.37902, CoreFX 4.700.19.40503), 64bit RyuJIT
DefaultJob : .NET Core 3.0.0-preview8-28405-07 (CoreCLR 4.700.19.37902, CoreFX 4.700.19.40503), 64bit RyuJIT
|
Ignore coverage.* files.
Bump version to 4.1.0 for change to target frameworks.
Use preview 8 of the .NET Core 3.0 SDK. Swap net451 for net461. Use Microsoft.NETFramework.ReferenceAssemblies to build on non-Windows platforms. Remove redundant MSBuildAllProjects properties.
Revert back to a minimum version of System.Memory for net461 and netstandard2.0.
Make .NET Standard 2.0 and .NET 4.6.1 the exception, rather than the default. Disable code analysis warning.
Use C# 8 features as suggested by Visual Studio, where approriate.
Fix warnings about disposable resources in the benchmarks.
Fix compilation of the benchmarks project on non-Windows platforms.
Drop TFM for StatsD benchmarks with .NET Core 2.0 as I don't think they're compiling properly on non-Windows platforms.
Fix the expression to ignore the benchmarks.
Enable nullable reference types. Fix violations and add annotations.
Fix misreported nullable annotations.
Use Visual Studio 2019 in AppVeyor CI.
Update to preview 9 of .NET Core 3.0.
Use PackageIcon instead of PackageIconUrl as described by https://github.com/NuGet/Home/wiki/Packaging-Icon-within-the-nupkg.
Update to release candidate 1 of .NET Core 3.0.
martincostello
changed the title
Update to the final release of the .NET Core 3.0 SDK. Use stable release of NuGet packages. Use stable release of C#.
maurofranchi
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to building with the .NET Core 3.0 SDK for the following benefits and changes:
Microsoft.NETFramework.ReferenceAssembliesto build on non-Windows platforms to remove the need for custom targets. This requires changing the minimum TFM tonet461.netstandard2.1TFM.MSBuildAllProjectsMSBuild properties.